Skip to content

Support ESLint v8 #29865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 16, 2021
Merged

Support ESLint v8 #29865

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
0746bf0
Support ESLint v8
ykzts Oct 13, 2021
2630aec
Run `yarn install`
ykzts Oct 13, 2021
81a6d23
Update @rushstack/eslint-patch to v1.0.8
ykzts Oct 13, 2021
8c9a472
Merge branch 'canary' into eslint8
ykzts Oct 13, 2021
38a049d
Add `root: true` to .eslintrc for tests
ykzts Oct 13, 2021
823d886
Merge remote-tracking branch 'origin/canary' into eslint8
ykzts Nov 9, 2021
d938024
Update eslint-plugin-react-hooks to v4.3.0
ykzts Nov 9, 2021
0042ce4
Apply suggestions from code review
ykzts Nov 9, 2021
f5daf22
update eslint-plugin-jsx-a11y and eslint-plugin-react
ykzts Nov 10, 2021
bc414b7
Merge remote-tracking branch 'origin/canary' into eslint8
ykzts Nov 10, 2021
519413c
Remove newer ESLint check
ykzts Nov 10, 2021
0019f7e
Merge remote-tracking branch 'ykzts/eslint8' into eslint8
ykzts Nov 10, 2021
b745898
Merge branch 'canary' into eslint8
ykzts Nov 10, 2021
9107dee
Merge branch 'canary' into eslint8
ykzts Nov 11, 2021
cb18a61
Merge branch 'canary' into eslint8
ykzts Nov 15, 2021
5711312
Merge branch 'canary' into eslint8
ykzts Nov 15, 2021
b86320e
Merge branch 'canary' into eslint8
ykzts Nov 16, 2021
c407d26
Update precompiled
timneutkens Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/create-next-app/create-app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ export async function createApp({
/**
* Default devDependencies.
*/
const devDependencies = ['eslint@7', 'eslint-config-next']
const devDependencies = ['eslint', 'eslint-config-next']
/**
* TypeScript projects will have type definitions and other devDependencies.
*/
Expand Down
8 changes: 4 additions & 4 deletions packages/eslint-config-next/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,17 +10,17 @@
},
"dependencies": {
"@next/eslint-plugin-next": "11.1.3-canary.67",
"@rushstack/eslint-patch": "^1.0.6",
"@typescript-eslint/parser": "^4.20.0",
"@rushstack/eslint-patch": "^1.0.8",
"@typescript-eslint/parser": "^5.0.0",
"eslint-import-resolver-node": "^0.3.4",
"eslint-import-resolver-typescript": "^2.4.0",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-import": "^2.25.2",
"eslint-plugin-jsx-a11y": "^6.4.1",
"eslint-plugin-react": "^7.23.1",
"eslint-plugin-react-hooks": "^4.2.0"
},
"peerDependencies": {
"eslint": "^7.23.0",
"eslint": "^7.23.0 || ^8.0.0-0",
"next": ">=10.2.0",
"typescript": ">=3.3.1"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/next/lib/eslint/runLintCheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ type Config = {
}

const requiredPackages = [
{ file: 'eslint/lib/api.js', pkg: 'eslint' },
{ file: 'eslint', pkg: 'eslint' },
{ file: 'eslint-config-next', pkg: 'eslint-config-next' },
]

Expand Down
10 changes: 8 additions & 2 deletions test/integration/telemetry/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,10 @@ describe('Telemetry CLI', () => {
})

it('emits telemetry for lint during build', async () => {
await fs.writeFile(path.join(appDir, '.eslintrc'), `{ "extends": "next" }`)
await fs.writeFile(
path.join(appDir, '.eslintrc'),
`{ "root": true, "extends": "next" }`
)
const { stderr } = await nextBuild(appDir, [], {
stderr: true,
env: { NEXT_TELEMETRY_DEBUG: 1 },
Expand All @@ -540,7 +543,10 @@ describe('Telemetry CLI', () => {
})

it('emits telemetry for `next lint`', async () => {
await fs.writeFile(path.join(appDir, '.eslintrc'), `{ "extends": "next" }`)
await fs.writeFile(
path.join(appDir, '.eslintrc'),
`{ "root": true, "extends": "next" }`
)
const { stderr } = await nextLint(appDir, [], {
stderr: true,
env: { NEXT_TELEMETRY_DEBUG: 1 },
Expand Down
Loading