Skip to content

add missing function call to normalize-catchall-routes test case #60777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 18, 2024
Merged

add missing function call to normalize-catchall-routes test case #60777

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8bdc298
add missing function call to `normalize-catchall-routes` test case
wiiiimm Jan 17, 2024
9cb3f80
Merge branch 'canary' into fix-missing-parallel-catchall-test-case
wiiiimm Jan 17, 2024
5bfd6ec
Merge branch 'canary' into fix-missing-parallel-catchall-test-case
wiiiimm Jan 18, 2024
c62bd75
added comment to test cases
wiiiimm Jan 18, 2024
e9ef5b4
updated test cases with correct comments
wiiiimm Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/next/src/build/normalize-catchall-routes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,10 @@ describe('normalizeCatchallRoutes', () => {

const initialAppPaths = JSON.parse(JSON.stringify(appPaths))

// normalize appPaths against catchAlls
normalizeCatchAllRoutes(appPaths)

// ensure values are correct after normalizing
expect(appPaths).toMatchObject(initialAppPaths)
})

Expand All @@ -36,8 +38,10 @@ describe('normalizeCatchallRoutes', () => {
],
}

// normalize appPaths against catchAlls
normalizeCatchAllRoutes(appPaths)

// ensure values are correct after normalizing
expect(appPaths).toMatchObject({
'/parallel-nested-catchall': ['/parallel-nested-catchall/page'],
'/parallel-nested-catchall/[...catchAll]': [
Expand Down Expand Up @@ -73,8 +77,10 @@ describe('normalizeCatchallRoutes', () => {
'/foo/[...catchAll]': ['/@slot/foo/[...catchAll]/page'],
}

// normalize appPaths against catchAlls
normalizeCatchAllRoutes(appPaths)

// ensure values are correct after normalizing
expect(appPaths).toMatchObject({
'/': [
'/page',
Expand Down Expand Up @@ -115,6 +121,10 @@ describe('normalizeCatchallRoutes', () => {

const initialAppPaths = JSON.parse(JSON.stringify(appPaths))

// normalize appPaths against catchAlls
normalizeCatchAllRoutes(appPaths)

// ensure values are correct after normalizing
expect(appPaths).toMatchObject(initialAppPaths)
})

Expand All @@ -126,8 +136,11 @@ describe('normalizeCatchallRoutes', () => {
}

const initialAppPaths = JSON.parse(JSON.stringify(appPaths))

// normalize appPaths against catchAlls
normalizeCatchAllRoutes(appPaths)

// ensure values are correct after normalizing
expect(appPaths).toMatchObject(initialAppPaths)
})
})