#41 Make sure region value is always string #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "region" field in "vipps_customer_address" table is defined (see db_schema.xml) as nullable field. Same time loaded from database the region value is returned by getRegion() function and result is used then in string-related functions (like, preg_replace(), strcasecmp()) where argument type is specified as string and null value causes TypeError like this: TypeError: strcasecmp(): Argument #1 ($string1) must be of type string, null given in [...] vendor/vipps/module-login/Model/VippsAddressManagement.php:385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "region" field in "vipps_customer_address" table is defined (see db_schema.xml) as nullable field. Same time loaded from database the region value is returned by getRegion() function and result is used then in string-related functions (like, preg_replace(), strcasecmp()) where argument type is specified as string and null value causes TypeError like this: TypeError: strcasecmp(): Argument #1 ($string1) must be of type string, null given in [...] vendor/vipps/module-login/Model/VippsAddressManagement.php:385