Skip to content

fix: add jsx dev runtime to optimizeDeps #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix: add jsx dev runtime to optimizeDeps #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/plugin-react/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export default defineConfig({

### jsxImportSource

Control where the JSX factory is imported from. For TS projects this is inferred from the tsconfig. If you have some React code outside JSX/TSX files, this will be used to detect the presence of React code and apply Fast Refresh.
Control where the JSX factory is imported from. Default to `'react'`

```js
react({ jsxImportSource: '@emotion/react' })
Expand Down
9 changes: 4 additions & 5 deletions packages/plugin-react/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export interface Options {
/**
* Control where the JSX factory is imported from.
* https://esbuild.github.io/api/#jsx-import-source
* For TS projects this is read from tsconfig
* @default 'react'
*/
jsxImportSource?: string
/**
Expand Down Expand Up @@ -91,6 +91,7 @@ export default function viteReact(opts: Options = {}): PluginOption[] {
// Provide default values for Rollup compat.
let devBase = '/'
const filter = createFilter(opts.include ?? defaultIncludeRE, opts.exclude)
const devRuntime = `${opts.jsxImportSource ?? 'react'}/jsx-dev-runtime`
let needHiresSourcemap = false
let isProduction = true
let projectRoot = process.cwd()
Expand Down Expand Up @@ -181,9 +182,7 @@ export default function viteReact(opts: Options = {}): PluginOption[] {
!ssr &&
(isJSX ||
(opts.jsxRuntime === 'classic'
? code.includes(
`${opts.jsxImportSource ?? 'react'}/jsx-dev-runtime`,
)
? code.includes(devRuntime)
: importReactRE.test(code)))
if (useFastRefresh) {
plugins.push([
Expand Down Expand Up @@ -280,7 +279,7 @@ export default function viteReact(opts: Options = {}): PluginOption[] {
// We can't add `react-dom` because the dependency is `react-dom/client`
// for React 18 while it's `react-dom` for React 17. We'd need to detect
// what React version the user has installed.
include: ['react'],
include: ['react', devRuntime],
},
resolve: {
dedupe: ['react', 'react-dom'],
Expand Down
1 change: 0 additions & 1 deletion playground/ssr-react/vite.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import react from '@vitejs/plugin-react'

export default defineConfig({
plugins: [react()],
optimizeDeps: { include: ['react/jsx-dev-runtime'] },
build: {
minify: false,
},
Expand Down