feat: suggest `vite-plugin-react-oxc` when using `rolldown-vite` #491

TheAlexLichter · 2025-06-03T14:42:45Z

Description

This PR introduces a log (warn) when using rolldown-vite and either:

vite-plugin-react,
or vite-plugin-react-swc (without any swc plugins set)

It recommends using vite-plugin-react-oxc and links to the Rolldown migration guide.

I'm planning on adding info regarding vite-plugin-react-oxc to it in another PR

…down-vite is detected

ArnaudBarre

I think that's a good way to make people aware of it, but maybe we should provide a way to disable the warning, but one extra config field for this feels too much. I'm curious of the opinion of other team member @patak-dev @sapphi-red @hi-ogawa

packages/plugin-react-swc/src/index.ts

packages/plugin-react/src/index.ts

TheAlexLichter · 2025-06-03T15:15:51Z

Thanks for your notes!

maybe we should provide a way to disable the warning, but one extra config field for this feels too much.

I had the same thoughts and didn't come up with a better solution so far. But maybe we could use an env var instead to avoid "one more config option" and cater to the needs of the few who want to disable it? 🤔

patak-dev · 2025-06-03T15:19:28Z

I think that's a good way to make people aware of it, but maybe we should provide a way to disable the warning, but one extra config field for this feels too much. I'm curious of the opinion of other team member @patak-dev @sapphi-red @hi-ogawa

I agree that there should be a way to disable the warning. If the idea is making vite-plugin-react-oxc the default, I think it is ok to have an option in the other plugins config to disable it.

TheAlexLichter · 2025-06-03T16:59:41Z

Added disableOxcRecommendation which is not set by default to both plugins 👍🏻

packages/plugin-react-swc/README.md

packages/plugin-react-swc/src/index.ts

sapphi-red · 2025-06-04T03:33:16Z

maybe we should provide a way to disable the warning, but one extra config field for this feels too much.

I had the same thoughts and didn't come up with a better solution so far. But maybe we could use an env var instead to avoid "one more config option" and cater to the needs of the few who want to disable it? 🤔

This isn't directly related, but implementing vitejs/vite#19937 in the future could help users filter out certain warnings more easily.

sapphi-red

Would you add a changelog entry?

packages/plugin-react-swc/src/index.ts

packages/plugin-react/src/index.ts

packages/plugin-react-swc/src/index.ts

Co-authored-by: 翠 <[email protected]>

| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.5.0 | 4.5.2 | ## [v4.5.2](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#452-2025-06-10) ##### Suggest `@vitejs/plugin-react-oxc` if rolldown-vite is detected [#491](vitejs/vite-plugin-react#491) Emit a log which recommends `@vitejs/plugin-react-oxc` when `rolldown-vite` is detected to improve performance and use Oxc under the hood. The warning can be disabled by setting `disableOxcRecommendation: false` in the plugin options. ##### Use `optimizeDeps.rollupOptions` instead of `optimizeDeps.esbuildOptions` for rolldown-vite [#489](vitejs/vite-plugin-react#489) This suppresses the warning about `optimizeDeps.esbuildOptions` being deprecated in rolldown-vite. ##### Add Vite 7-beta to peerDependencies range [#497](vitejs/vite-plugin-react#497) React plugins are compatible with Vite 7, this removes the warning when testing the beta. ## [v4.5.1](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#451-2025-06-03) ##### Add explicit semicolon in preambleCode [#485](vitejs/vite-plugin-react#485) This fixes an edge case when using HTML minifiers that strips line breaks aggressively.

| datasource | package | from | to | | ---------- | -------------------- | ----- | ----- | | npm | @vitejs/plugin-react | 4.5.0 | 4.6.0 | ## [v4.6.0](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#460-2025-06-23) ##### Add raw Rolldown support This plugin only worked with Vite. But now it can also be used with raw Rolldown. The main purpose for using this plugin with Rolldown is to use react compiler. ## [v4.5.2](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#452-2025-06-10) ##### Suggest `@vitejs/plugin-react-oxc` if rolldown-vite is detected [#491](vitejs/vite-plugin-react#491) Emit a log which recommends `@vitejs/plugin-react-oxc` when `rolldown-vite` is detected to improve performance and use Oxc under the hood. The warning can be disabled by setting `disableOxcRecommendation: false` in the plugin options. ##### Use `optimizeDeps.rollupOptions` instead of `optimizeDeps.esbuildOptions` for rolldown-vite [#489](vitejs/vite-plugin-react#489) This suppresses the warning about `optimizeDeps.esbuildOptions` being deprecated in rolldown-vite. ##### Add Vite 7-beta to peerDependencies range [#497](vitejs/vite-plugin-react#497) React plugins are compatible with Vite 7, this removes the warning when testing the beta. ## [v4.5.1](https://github.com/vitejs/vite-plugin-react/blob/HEAD/packages/plugin-react/CHANGELOG.md#451-2025-06-03) ##### Add explicit semicolon in preambleCode [#485](vitejs/vite-plugin-react#485) This fixes an edge case when using HTML minifiers that strips line breaks aggressively.

feat: log recommendation to switch to vite-plugin-react-oxc when roll…

7679e49

…down-vite is detected

ArnaudBarre reviewed Jun 3, 2025

View reviewed changes

packages/plugin-react-swc/src/index.ts Outdated Show resolved Hide resolved

packages/plugin-react-swc/src/index.ts Outdated Show resolved Hide resolved

packages/plugin-react/src/index.ts Outdated Show resolved Hide resolved

TheAlexLichter mentioned this pull request Jun 3, 2025

chore(readme): add plugin-react-oxc to the table #490

Merged

TheAlexLichter added 3 commits June 3, 2025 18:54

chore(swc): check for mutateSwcOptions and fix plugin check

6b41764

chore(react): do not recommend if babel option is set

6008c90

feat: introduce option to disable the warning

0979cd1

TheAlexLichter mentioned this pull request Jun 3, 2025

docs(rolldown): add @vitejs/plugin-react-oxc recommendation vitejs/vite#20152

Merged

docs: info for oxc option

d52a6c2

sapphi-red reviewed Jun 4, 2025

View reviewed changes

packages/plugin-react-swc/README.md Outdated Show resolved Hide resolved

sapphi-red reviewed Jun 4, 2025

View reviewed changes

packages/plugin-react-swc/src/index.ts Outdated Show resolved Hide resolved

TheAlexLichter added 5 commits June 4, 2025 09:02

fix: correct vite pkg name

2b0a0ce

chore: use config.logger.warn

8ee3ad1

chore: check for babel hooks and disable if needed

7b55598

Merge branch 'main' into feat/recommend-oxc-plugin-if-rolldown

54076c7

fix: dupe import

63290ea

sapphi-red reviewed Jun 5, 2025

View reviewed changes

ArnaudBarre approved these changes Jun 5, 2025

View reviewed changes

packages/plugin-react-swc/src/index.ts Outdated Show resolved Hide resolved

TheAlexLichter and others added 7 commits June 5, 2025 09:45

Update packages/plugin-react-swc/src/index.ts

0c2fd28

Co-authored-by: 翠 <[email protected]>

Update packages/plugin-react-swc/src/index.ts

d74feca

Co-authored-by: 翠 <[email protected]>

Update packages/plugin-react/src/index.ts

5f19ec9

Co-authored-by: 翠 <[email protected]>

Update packages/plugin-react-swc/src/index.ts

04eabc0

Co-authored-by: 翠 <[email protected]>

Update packages/plugin-react/src/index.ts

4d367b5

Co-authored-by: 翠 <[email protected]>

chore: add changelog

a6f523d

chore: remove verbose comments

2ac7620

ArnaudBarre approved these changes Jun 5, 2025

View reviewed changes

sapphi-red approved these changes Jun 6, 2025

View reviewed changes

sapphi-red merged commit c450133 into vitejs:main Jun 6, 2025
8 checks passed

TheAlexLichter deleted the feat/recommend-oxc-plugin-if-rolldown branch June 6, 2025 09:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: suggest `vite-plugin-react-oxc` when using `rolldown-vite` #491

feat: suggest `vite-plugin-react-oxc` when using `rolldown-vite` #491

Uh oh!

TheAlexLichter commented Jun 3, 2025

Uh oh!

ArnaudBarre left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheAlexLichter commented Jun 3, 2025

Uh oh!

patak-dev commented Jun 3, 2025

Uh oh!

TheAlexLichter commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Jun 4, 2025

Uh oh!

sapphi-red left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: suggest vite-plugin-react-oxc when using rolldown-vite #491

feat: suggest vite-plugin-react-oxc when using rolldown-vite #491

Uh oh!

Conversation

TheAlexLichter commented Jun 3, 2025

Description

Uh oh!

ArnaudBarre left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TheAlexLichter commented Jun 3, 2025

Uh oh!

patak-dev commented Jun 3, 2025

Uh oh!

TheAlexLichter commented Jun 3, 2025

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Jun 4, 2025

Uh oh!

sapphi-red left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

feat: suggest `vite-plugin-react-oxc` when using `rolldown-vite` #491

feat: suggest `vite-plugin-react-oxc` when using `rolldown-vite` #491