docs: minor fixes for punctuation and grammar #20653
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
reviewed
Aug 20, 2025
docs/guide/assets.md
Outdated
| @@ -129,7 +129,7 @@ const imgUrl = new URL('./img.png', import.meta.url).href | |||
| document.getElementById('hero-img').src = imgUrl | |||
| ``` | |||
|
|
|||
| This works natively in modern browsers - in fact, Vite doesn't need to process this code at all during development! | |||
| This works natively in modern browsers – in fact, Vite doesn't need to process this code at all during development! | |||
There was a problem hiding this comment.
Suggested change
| This works natively in modern browsers – in fact, Vite doesn't need to process this code at all during development! | |
| This works natively in modern browsers - in fact, Vite doesn't need to process this code at all during development! |
I'm reverting this for now as we have many places with the same pattern. (And personally I don't think it's a big issue to fix in practice).
There was a problem hiding this comment.
Hyphens are distinct from m dashes and n dashes and should not be used as a substitute for these long dashes.
bluwy
changed the title
bluwy
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.