fix(create-vite): rmSync chinese file #20724 #20730
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hub.com/435012357/vite-rm-file-bug into feature/create-vite-rm-chinese-file-bug
- 将函数名 "assync" 更正为 "async" - 确保 emptyDir 函数正确声明为异步函数 - 修复潜在的运行时错误及类型检查问题
…hub.com/435012357/vite-rm-file-bug into feature/create-vite-rm-chinese-file-bug
- 修正 `fs.promises.rm` 调用处缺少结束大括号的问题 - 保证目录内文件逐个递归删除操作正常执行 - 避免因语法错误导致清空目录功能失效
435012357
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue where
rmSyncfails to remove files and folders with Chinese names when using create-vite on Node.js 24.Changes
fs.rmSync()withfsp.rm()promise variantFixes #20724