Fully overlap model execution #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianmu-li
force-pushed
the
test_async
branch
3 times, most recently
from
778161a to
68609db
Compare
tianmu-li
changed the title
tianmu-li
requested review from
kzawora-intel,
xuechendi,
mswiniarsk and
adobrzyn
as code owners
tianmu-li
force-pushed
the
test_async
branch
from
c9f8e34 to
b2a376d
Compare
|
Half overlapping. There is still one sync point at https://github.com/vllm-project/vllm-gaudi/pull/134/files#diff-5ffdc7547fbc10ff45e9791caaef30c306a59a0e3f7c9515569f342baed8c0e2R116, but I can't find a safe way to remove it. |
Signed-off-by: Tianmu Li <[email protected]> Incorporate commit by Marcin Signed-off-by: Tianmu Li <[email protected]> Pre-commit fix Signed-off-by: Tianmu Li <[email protected]> Remove unneeded change Signed-off-by: Tianmu Li <[email protected]> WIP Signed-off-by: Tianmu Li <[email protected]> pre-commit fix Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
…racy fix WIP Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
tianmu-li
force-pushed
the
test_async
branch
from
b2a376d to
fa3b2c0
Compare
Signed-off-by: Tianmu Li <[email protected]>
xuechendi
reviewed
Sep 11, 2025
xuechendi
reviewed
Sep 11, 2025
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
Signed-off-by: Tianmu Li <[email protected]>
|
/run-gaudi-tests |
xuechendi
approved these changes
Sep 12, 2025
|
Failed on spec decode when async_scheduler is not on, cancel the run |
…oken_ids behavior with non-spec Signed-off-by: Tianmu Li <[email protected]>
…etween spec decode and async Signed-off-by: Tianmu Li <[email protected]>
|
Fixed the issue by preventing concatenation of decode_sampled_token_ids and prefill_sampled_token_ids when not using async_scheduling. |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
|
/run-gaudi-tests |
kdamaszk
pushed a commit
to kdamaszk/vllm-gaudi
that referenced
this pull request
Sep 18, 2025
Dependent on vllm-project/vllm#23569 --------- Signed-off-by: Tianmu Li <[email protected]> Co-authored-by: Chendi.Xue <[email protected]>
mswiniarsk
pushed a commit
that referenced
this pull request
Sep 18, 2025
Porting changes from main branch: #134 i #184 Author: Tianmu Li <[email protected]> --------- Signed-off-by: Tianmu Li <[email protected]> Co-authored-by: Tianmu Li <[email protected]> Co-authored-by: Chendi.Xue <[email protected]>
slokesha
pushed a commit
to slokesha/vllm-gaudi
that referenced
this pull request
Sep 24, 2025
Dependent on vllm-project/vllm#23569 --------- Signed-off-by: Tianmu Li <[email protected]> Co-authored-by: Chendi.Xue <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on vllm-project/vllm#23569