Skip to content

[Bugfix] Fix max image feature size for Llava-one-vision #12104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 16, 2025
Merged

[Bugfix] Fix max image feature size for Llava-one-vision #12104

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e12a4d
fix
ywang96 Jan 16, 2025
c53d696
fix
ywang96 Jan 16, 2025
53f97ee
Fix and add tests
DarkLight1337 Jan 16, 2025
7fbe17b
Add note
DarkLight1337 Jan 16, 2025
bd712ea
Format
DarkLight1337 Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions vllm/model_executor/models/llava_onevision.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@

# For profile run
_MAX_FRAMES_PER_VIDEO = 16
_MAX_IMAGE_SIZE_PLACEHOLDER = 12288


class LlavaOnevisionVideoPixelInputs(TypedDict):
Expand Down Expand Up @@ -101,6 +102,17 @@ def get_hf_processor(self):
def get_supported_mm_limits(self) -> Mapping[str, Optional[int]]:
return {"image": None, "video": None}

def get_max_image_tokens(self) -> int:

target_width, target_height = self.get_image_size_with_most_features()

# FIXME: This is in fact not accurate and we compare with a placeholder.
return max(
self.get_num_image_tokens(
image_width=target_width,
image_height=target_height,
), _MAX_IMAGE_SIZE_PLACEHOLDER)

def get_mm_max_tokens_per_item(self, seq_len: int) -> Mapping[str, int]:
return {
"image": self.get_max_image_tokens(),
Expand Down
Loading