Skip to content

[V1][Minor] Remove outdated comment #12928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2025
Merged

[V1][Minor] Remove outdated comment #12928

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions vllm/v1/core/kv_cache_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,7 @@ def get_num_common_prefix_blocks(

While all scheduled requests must be in the RUNNING state, the inverse
is not necessarily true. There may be RUNNING requests that are not
scheduled in the current step. As of 1/1/2025, the scheduler does not
allow this case, but it is possible in the future, as we allow more
flexible scheduling.
scheduled in the current step.

This can result in an edge case where the number of common prefix blocks
is 0, even though all scheduled requests share a common prefix. This
Expand Down