Skip to content

Conversation

gshtras
Copy link
Collaborator

@gshtras gshtras commented Feb 10, 2025

Fix ROCm build falling back to CPU due to missing torch.version.hip check
To fix a regression from #12874

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@gshtras gshtras changed the title Fix ROCm build falling back to CPU due to missing torch.version.hip c… [Build][Bug] Fix ROCm build falling back to CPU due to missing torch.version.hip Feb 10, 2025
@mergify mergify bot added the ci/build label Feb 10, 2025
@gshtras
Copy link
Collaborator Author

gshtras commented Feb 10, 2025

Looks like a duplicate of #13022

@gshtras gshtras closed this Feb 10, 2025
@gshtras gshtras deleted the hip_build_fix branch April 7, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant