Skip to content

Conversation

qli88
Copy link
Contributor

@qli88 qli88 commented Feb 23, 2025

  1. Add GPUs tweaks for AMD; 2. Allow triton-fa for prefill stage in MLA path; 3. Add MoE config for MI300X

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@houseroad
Copy link
Collaborator

Any idea, how much is the perf improvement?

@qli88
Copy link
Contributor Author

qli88 commented Feb 23, 2025

Any idea, how much is the perf improvement?

@houseroad With this PR the upstream repo's perf is very close to that of our own repo. @hongxiayang will give you more details about it.

@mgoin mgoin requested a review from LucasWilkinson February 23, 2025 14:57
@hongxiayang hongxiayang added the rocm Related to AMD ROCm label Feb 24, 2025
…LA path; 3. Add MoE config for MI300X

Signed-off-by: qli88 <[email protected]>
Signed-off-by: qli88 <[email protected]>
@qli88 qli88 force-pushed the upstream_dsv3_0222 branch from 5a48077 to 5cd8601 Compare February 26, 2025 18:47
Signed-off-by: qli88 <[email protected]>
Signed-off-by: qli88 <[email protected]>
Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me, left on nit, would be nice to try to alias these to a common interface in the constructor in the future since its getting a bit messy now, especially since the are all called with causal true and false

@LucasWilkinson LucasWilkinson added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 27, 2025
@LucasWilkinson LucasWilkinson enabled auto-merge (squash) February 27, 2025 18:20
@LucasWilkinson LucasWilkinson merged commit 8294773 into vllm-project:main Feb 27, 2025
52 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Mar 3, 2025
gshtras added a commit to ROCm/vllm that referenced this pull request Mar 4, 2025
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants