-
-
Notifications
You must be signed in to change notification settings - Fork 10.1k
[core] Perf improvement for DSv3 on AMD GPUs #13718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
2b2b5cd
to
451b2ef
Compare
Any idea, how much is the perf improvement? |
@houseroad With this PR the upstream repo's perf is very close to that of our own repo. @hongxiayang will give you more details about it. |
…LA path; 3. Add MoE config for MI300X Signed-off-by: qli88 <[email protected]>
Signed-off-by: qli88 <[email protected]>
5a48077
to
5cd8601
Compare
Signed-off-by: qli88 <[email protected]>
Signed-off-by: qli88 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me, left on nit, would be nice to try to alias these to a common interface in the constructor in the future since its getting a bit messy now, especially since the are all called with causal true and false
Signed-off-by: qli88 <[email protected]>
)" This reverts commit 8294773.
Signed-off-by: qli88 <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
Signed-off-by: qli88 <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.