[Frontend] Fix typo in tool chat templates for llama3.2 and toolace #14501
Conversation
Signed-off-by: Ben Jackson <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
| {%- for param in tool_call.arguments %} | ||
| {{- param + '=' -}} | ||
| {{- "%sr" | format(tool_call.arguments[param]) -}} | ||
| {{- "%s" | format(tool_call.arguments[param]) -}} |
There was a problem hiding this comment.
I think this was actually supposed to be %r but I can't recall the scenario where it matters.
https://docs.python.org/3/library/stdtypes.html#printf-style-string-formatting
In any case, clearly %sr is wrong, so thanks for the fix!
github-actions
bot
added
the
ready
…llm-project#14501) Signed-off-by: Ben Jackson <[email protected]> Signed-off-by: Louis Ulmer <[email protected]>
…llm-project#14501) Signed-off-by: Ben Jackson <[email protected]>
…llm-project#14501) Signed-off-by: Ben Jackson <[email protected]> Signed-off-by: Yang Wang <[email protected]>
…llm-project#14501) Signed-off-by: Ben Jackson <[email protected]>
…llm-project#14501) Signed-off-by: Ben Jackson <[email protected]> Signed-off-by: Mu Huai <[email protected]>
Fix a stray
rI noticed while debugging tool calling @mdepinet