Skip to content

[Bugfix] Fix incorrect qwen2.5-vl attention mask pre-computation #15200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 21, 2025
Merged

[Bugfix] Fix incorrect qwen2.5-vl attention mask pre-computation #15200

merged 3 commits into from
Mar 21, 2025

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Mar 20, 2025 •
edited by github-actions bot
Loading

FIX #15122
FIX #15197

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Isotr0py
Isotr0py commented Mar 20, 2025
View reviewed changes
This was referenced Mar 20, 2025
Closed
Closed
@Isotr0py
add regression test
874842e 
Signed-off-by: Isotr0py <[email protected]>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) March 20, 2025 17:34
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 20, 2025
@ywang96 ywang96 mentioned this pull request Mar 20, 2025
Closed
@vllm-bot vllm-bot merged commit 1e50834 into vllm-project:main Mar 21, 2025
40 of 43 checks passed
@Isotr0py Isotr0py deleted the fix-qwen2_5-vl-windows branch March 21, 2025 03:15
@Isotr0py Isotr0py mentioned this pull request Mar 21, 2025
Merged
@DarkLight1337 DarkLight1337 mentioned this pull request Mar 25, 2025
Closed
1 task
erictang000 pushed a commit to erictang000/vllm that referenced this pull request Mar 25, 2025
@Isotr0py @erictang000
[Bugfix] Fix incorrect qwen2.5-vl attention mask pre-computation (vll…
33bc80a 
…m-project#15200)

Signed-off-by: Isotr0py <[email protected]>
@Stonesjtu
Copy link

Stonesjtu commented Mar 27, 2025 •
edited
Loading

@Isotr0py we found v0.8.1 introduces some words (~10%) missing when using Qwen2.5-VL for OCR tasks, probably the results between the correct and wrong version is not so obvious.

And v0.7.3 works perfect. Hope this information could help

@DarkLight1337
Copy link
Member

This PR is in v0.8.2, so if you update to the latest version the problem should be solved

@DarkLight1337 DarkLight1337 mentioned this pull request Mar 27, 2025
Closed
1 task
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@Isotr0py @lulmer
[Bugfix] Fix incorrect qwen2.5-vl attention mask pre-computation (vll…
b66fe65 
…m-project#15200)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@Lizuole007
Copy link

@Isotr0py we found v0.8.1 introduces some words (~10%) missing when using Qwen2.5-VL for OCR tasks, probably the results between the correct and wrong version is not so obvious.

And v0.7.3 works perfect. Hope this information could help

Have you solved this problem?

@Stonesjtu
Copy link

@Isotr0py we found v0.8.1 introduces some words (~10%) missing when using Qwen2.5-VL for OCR tasks, probably the results between the correct and wrong version is not so obvious.
And v0.7.3 works perfect. Hope this information could help

Have you solved this problem?

you can either upgrade to v0.8.2 or downgrade to 0.7.3

@DarkLight1337 DarkLight1337 mentioned this pull request Apr 14, 2025
Closed
1 task
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@Isotr0py @shreyankg
[Bugfix] Fix incorrect qwen2.5-vl attention mask pre-computation (vll…
39a13f9 
…m-project#15200)

Signed-off-by: Isotr0py <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@Isotr0py
[Bugfix] Fix incorrect qwen2.5-vl attention mask pre-computation (vll…
87ee921 
…m-project#15200)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Qwen2.5-VL Cannot Output Correct Content under 0.8.1 [Bug]: Qwen VL 2.5 doesn't work in v0.8.0 - again
5 participants
@Isotr0py @Stonesjtu @DarkLight1337 @Lizuole007 @vllm-bot