Skip to content

[V1] TPU CI - Fix test_compilation.py #15570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

[V1] TPU CI - Fix test_compilation.py #15570

merged 1 commit into from
Mar 26, 2025

Conversation

alexm-redhat
Copy link
Collaborator

Fixes the test_compilation.py to work the updated V1 TPU code.

@alexm-redhat
[V1] TPU CI - Fix test_compilation.py
e178604 
Signed-off-by: Alexander Matveev <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@alexm-redhat alexm-redhat self-assigned this Mar 26, 2025
@alexm-redhat alexm-redhat requested a review from mgoin March 26, 2025 19:31
@mergify mergify bot added the ci/build label Mar 26, 2025
robertgshaw2-redhat
robertgshaw2-redhat reviewed Mar 26, 2025
View reviewed changes
@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) March 26, 2025 19:37
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Mar 26, 2025
@mgoin mgoin added tpu Related to Google TPUs v1 labels Mar 26, 2025
lsy323
lsy323 reviewed Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@lsy323 lsy323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @alexm-redhat !

tests/tpu/test_compilation.py
# We should only trigger Dynamo compilation 2 times:
# 1. Forward pass without kv_caches
# 2. Forward pass with kv_caches
# Check we have 4 compiled codes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Check we have 4 compiled codes
# Check we have 2 compiled codes

@robertgshaw2-redhat robertgshaw2-redhat merged commit 9d119a8 into main Mar 26, 2025
27 checks passed
@robertgshaw2-redhat robertgshaw2-redhat deleted the fix_comp branch March 26, 2025 21:51
Alex4210987 pushed a commit to LeiWang1999/vllm-bitblas that referenced this pull request Apr 5, 2025
@alexm-redhat @Alex4210987
[V1] TPU CI - Fix test_compilation.py (vllm-project#15570)
0069e72 
Signed-off-by: Alexander Matveev <[email protected]>
Signed-off-by: xinyuxiao <[email protected]>
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
@alexm-redhat @lulmer
[V1] TPU CI - Fix test_compilation.py (vllm-project#15570)
930df2b 
Signed-off-by: Alexander Matveev <[email protected]>
Signed-off-by: Louis Ulmer <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request Apr 17, 2025
Closed
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@alexm-redhat @lk-chen
[V1] TPU CI - Fix test_compilation.py (vllm-project#15570)
0d5e0b2 
Signed-off-by: Alexander Matveev <[email protected]>
shreyankg pushed a commit to shreyankg/vllm that referenced this pull request May 3, 2025
@alexm-redhat @shreyankg
[V1] TPU CI - Fix test_compilation.py (vllm-project#15570)
51a31e7 
Signed-off-by: Alexander Matveev <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@alexm-redhat
[V1] TPU CI - Fix test_compilation.py (vllm-project#15570)
7232ab3 
Signed-off-by: Alexander Matveev <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

+1 more reviewer

@lsy323 lsy323 lsy323 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@alexm-redhat alexm-redhat

Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexm-redhat @mgoin @lsy323 @robertgshaw2-redhat