Skip to content

[ROCm][Bugfix][FP8] Make fp8 quant respect fused modules mapping #16031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2025
Merged

[ROCm][Bugfix][FP8] Make fp8 quant respect fused modules mapping #16031

merged 2 commits into from
Apr 8, 2025

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Apr 3, 2025 •
edited
Loading

I thought this would be a better fix for the issue given in #15900

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mgoin mgoin mentioned this pull request Apr 3, 2025
Closed
@mgoin mgoin added bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed labels Apr 6, 2025
@mgoin mgoin changed the title Make fp8 quant respect fused modules mapping [ROCm][Bugfix][FP8] Make fp8 quant respect fused modules mapping Apr 7, 2025
@mgoin mgoin added the rocm Related to AMD ROCm label Apr 7, 2025
@tlrmchlsmth tlrmchlsmth merged commit 21802c4 into vllm-project:main Apr 8, 2025
62 checks passed
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
@mgoin @yangw-dev
[ROCm][Bugfix][FP8] Make fp8 quant respect fused modules mapping (vll…
f22bf8e 
…m-project#16031)

Signed-off-by: mgoin <[email protected]>
Signed-off-by: Yang Wang <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@mgoin @lk-chen
[ROCm][Bugfix][FP8] Make fp8 quant respect fused modules mapping (vll…
9437198 
…m-project#16031)

Signed-off-by: mgoin <[email protected]>
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@mgoin
[ROCm][Bugfix][FP8] Make fp8 quant respect fused modules mapping (vll…
76db257 
…m-project#16031)

Signed-off-by: mgoin <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlrmchlsmth tlrmchlsmth tlrmchlsmth approved these changes

@ProExpertProg ProExpertProg ProExpertProg approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

Assignees
No one assigned
Labels
bug Something isn't working ready ONLY add when PR is ready to merge/full CI is needed rocm Related to AMD ROCm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @tlrmchlsmth @ProExpertProg