Skip to content

Conversation

luccafong
Copy link
Collaborator

@luccafong luccafong commented Apr 6, 2025

  1. TeleChat2ForCausalLM inherits LlamaForCausalLM which requires a change to _init_model signature
  2. irope is not supported for V0 attention, we need to add the parameter and warning.

fix model init for TeleChat2ForCausalLM and llama4 V0

Signed-off-by: Lu Fang <[email protected]>
Signed-off-by: Lu Fang <[email protected]>
Copy link

github-actions bot commented Apr 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@luccafong luccafong marked this pull request as ready for review April 6, 2025 04:10
@vllm-bot vllm-bot merged commit 620fc2d into vllm-project:main Apr 6, 2025
8 of 11 checks passed
lulmer pushed a commit to lulmer/vllm that referenced this pull request Apr 7, 2025
lengrongfu pushed a commit to lengrongfu/vllm that referenced this pull request Apr 7, 2025
yangw-dev pushed a commit to yangw-dev/vllm that referenced this pull request Apr 21, 2025
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants