Skip to content

[Model] Allow the use of sliding window in Qwen2 #17772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged

[Model] Allow the use of sliding window in Qwen2 #17772

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8ee5ff3
update
inkcherry May 7, 2025
57fd105
use constant
inkcherry May 7, 2025
a214e2a
format
inkcherry May 7, 2025
0a0e447
update
inkcherry May 11, 2025
cc9b656
revert
inkcherry May 12, 2025
d067c05
update
inkcherry May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions vllm/model_executor/models/qwen2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,14 +276,14 @@ def __init__(self,
# TODO (@robertgshaw2): see if this can be moved out
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this comment seems to come from @robertgshaw2-redhat , do you have any ideas?

if (cache_config.sliding_window is not None
and hasattr(config, "max_window_layers")):
raise ValueError("Sliding window for some but all layers is not "
"supported. This model uses sliding window "
"but `max_window_layers` = {} is less than "
"`num_hidden_layers` = {}. Please open an issue "
"to discuss this feature.".format(
config.max_window_layers,
config.num_hidden_layers,
))
assert config.max_window_layers == config.num_hidden_layers, (
"Sliding window for some but all layers is not supported. "
"This model uses sliding window but `max_window_layers` = {} "
"is less than `num_hidden_layers` = {}. Please open an issue "
"to discuss this feature.".format(
config.max_window_layers,
config.num_hidden_layers,
))

self.config = config
self.quant_config = quant_config
Expand Down