Skip to content

Add support for loading torchao models with AOPerModuleConfig #17826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Add support for loading torchao models with AOPerModuleConfig #17826

merged 3 commits into from
May 14, 2025

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented May 8, 2025 •
edited by github-actions bot
Loading

Summary:
att, needs pytorch/ao#2186 to be landed

Test Plan:
python tests/quantization/test_torchao.py

Reviewers:

Subscribers:

Tasks:

Tags:

@jerryzh168
Add support for loading torchao models quantized with `AOPerModuleCon…
d3a80e9 
…fig`

Summary:
att, needs pytorch/ao#2186 to be landed

Test Plan:
python tests/quantization/test_torchao.py

Reviewers:

Subscribers:

Tasks:

Tags:

Signed-off-by: Jerry Zhang <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented May 8, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@jerryzh168 jerryzh168 changed the title Add support for loading torchao models quantized with `AOPerModuleCon… Add support for loading torchao models with AOPerModuleConfig May 8, 2025
@jerryzh168
fix type
ecaa5b4 
Signed-off-by: Jerry Zhang <[email protected]>
luccafong
luccafong approved these changes May 8, 2025
View reviewed changes
@jerryzh168
address comment
128d3aa 
Signed-off-by: Jerry Zhang <[email protected]>
@jerryzh168
Copy link
Contributor Author

@mgoin @houseroad can you take a look

houseroad
houseroad reviewed May 14, 2025
View reviewed changes
tests/quantization/test_torchao.py
max_tokens=32)

assert output
print(output)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: assert output, f"output is {output}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update in next change, feel free to merge

houseroad
houseroad approved these changes May 14, 2025
View reviewed changes
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks legit.

@houseroad houseroad added ready ONLY add when PR is ready to merge/full CI is needed torchao TorchAO related labels May 14, 2025
@houseroad houseroad merged commit 7974736 into vllm-project:main May 14, 2025
59 checks passed
@markmc markmc mentioned this pull request May 20, 2025
Closed
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@jerryzh168
Add support for loading torchao models with AOPerModuleConfig (vllm…
e18b87d 
…-project#17826)

Signed-off-by: Jerry Zhang <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@jerryzh168 @minpeter
Add support for loading torchao models with AOPerModuleConfig (vllm…
5579cbc 
…-project#17826)

Signed-off-by: Jerry Zhang <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houseroad houseroad houseroad approved these changes

@luccafong luccafong luccafong approved these changes

@mgoin mgoin Awaiting requested review from mgoin mgoin is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@tlrmchlsmth tlrmchlsmth Awaiting requested review from tlrmchlsmth tlrmchlsmth is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed torchao TorchAO related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerryzh168 @houseroad @luccafong