Skip to content

[Misc] Consolidate Audio tests into multimodal common generation tests #18214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 16, 2025
Merged

[Misc] Consolidate Audio tests into multimodal common generation tests #18214

merged 22 commits into from
May 16, 2025

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented May 15, 2025 •
edited by github-actions bot
Loading

Isotr0py added 21 commits May 2, 2025 17:41
@Isotr0py
refactor vlm test runner to support audio input
12ba7b4 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
add mixed modality input
c0486f6 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix model loading
a1f9ef8 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
Merge remote-tracking branch 'upstream/main' into qwen25-omni-test
6e5aaf2 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix tests
f5b23c4 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix aspect ratio tests
f1a06a0 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
add helper class
c43e3ce 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
rename
ee1d37b 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
make mypy happy
a04edd0 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
expose video data
4d996c1 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
remove runner mm_key
00ca64d 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
add video to mix modality test
9a55fa5 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
Merge remote-tracking branch 'origin/qwen25-omni-test' into audio-test
cf27d8e 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
integrate audio tests
36903f6 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
add audio test
8a5981a 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
clean up ultravox test
63d23b9 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
align vllm and hf outputs
c42edb4 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix audio prompt building
b1b5251 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
code format
b01d02b 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
fix types
c042ccf 
Signed-off-by: Isotr0py <[email protected]>
@Isotr0py
correct annotations
bccb7b4 
Signed-off-by: Isotr0py <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the multi-modality Related to multi-modality (#4194) label May 15, 2025
Isotr0py
Isotr0py commented May 15, 2025
View reviewed changes
tests/models/multimodal/generation/test_common.py
@@ -158,6 +158,17 @@
image_size_factors=[(), (0.25,), (0.25, 0.25, 0.25), (0.25, 0.2, 0.15)],
marks=[pytest.mark.core_model, pytest.mark.cpu_model],
),
"ultravox": VLMTestInfo(
models = ["fixie-ai/ultravox-v0_5-llama-3_2-1b"],
test_type=VLMTestType.AUDIO,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since ultravox's hf runner doesn't support multi-audios input, I will add multi-audio test type with missing Qwen2-Audio test together in a following PR.

DarkLight1337
DarkLight1337 approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, should be good as long as tests pass. Thanks for working on this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) May 16, 2025 07:18
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 16, 2025
@DarkLight1337 DarkLight1337 merged commit 390ec88 into vllm-project:main May 16, 2025
57 checks passed
@Isotr0py Isotr0py deleted the audio-test branch May 16, 2025 09:19
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@Isotr0py
[Misc] Consolidate Audio tests into multimodal common generation tests (
29ce896 
vllm-project#18214)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@Isotr0py @minpeter
[Misc] Consolidate Audio tests into multimodal common generation tests (
d38d1c8 
vllm-project#18214)

Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
multi-modality Related to multi-modality (#4194) ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Isotr0py @DarkLight1337