-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[Bugfix] Fix test_eagle test #18223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Fix test_eagle test #18223
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Lucia Fang <[email protected]>
Signed-off-by: Lucia Fang <[email protected]>
@@ -158,6 +159,11 @@ def __exit__(self, exc_type, exc_val, exc_tb): | |||
# Make mock_get_layers return different values for each call | |||
mock_get_layers.side_effect = [target_attn_layers, all_attn_layers] | |||
|
|||
# Setup mock for pp group to return the appropriate value for world size | |||
mock_pp_group = mock.MagicMock() | |||
mock_pp_group.world_size = 2 if method == "eagle" else 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to cover eagle3?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else fall into eagle3, algin with logic in 177 to 184
LGTM! |
Signed-off-by: Lucia Fang <[email protected]> Signed-off-by: Yuqi Zhang <[email protected]>
Signed-off-by: Lucia Fang <[email protected]> Signed-off-by: minpeter <[email protected]>
V1 test failed in trunk:
Fix test for
pytest -v tests/v1/spec_decode/test_eagle.py
Before changes, we got below for test_load_model
Now: