Skip to content

[Deprecation] Disallow pos-args other than model when initializing LLM #18802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 29, 2025
Merged

[Deprecation] Disallow pos-args other than model when initializing LLM #18802

merged 4 commits into from
May 29, 2025

Conversation

DarkLight1337
Copy link
Member

First deprecated in #9424, should be safe to remove now.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
@DarkLight1337 DarkLight1337 requested a review from mgoin May 28, 2025 03:48
@mergify mergify bot added the frontend label May 28, 2025
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@DarkLight1337
Fix
8a2af9a 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Update
5ccf60e 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Remove test
9261d18 
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 requested a review from youkaichao May 28, 2025 16:02
youkaichao
youkaichao approved these changes May 29, 2025
View reviewed changes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since we have the deprecation warning for a long while.

@vllm-bot vllm-bot merged commit c290340 into vllm-project:main May 29, 2025
61 of 63 checks passed
@DarkLight1337 DarkLight1337 deleted the deprecate-llm-pos-args branch May 29, 2025 16:37
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@DarkLight1337 @amitm02
[Deprecation] Disallow pos-args other than model when initializing …
18ef220 
…`LLM` (vllm-project#18802)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: amit <[email protected]>
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
@DarkLight1337 @amitm02
[Deprecation] Disallow pos-args other than model when initializing …
d2495ba 
…`LLM` (vllm-project#18802)

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: amit <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youkaichao youkaichao youkaichao approved these changes

@njhill njhill Awaiting requested review from njhill

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@mgoin mgoin Awaiting requested review from mgoin

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DarkLight1337 @youkaichao @vllm-bot