Skip to content

Conversation

yaochengji
Copy link
Collaborator

@yaochengji yaochengji commented May 28, 2025

Fix test_moe_pallas.py. We will get

E               AttributeError: '_OpNamespace' 'xla' object has no attribute 'gmm'` 

without this fix.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@yaochengji yaochengji requested a review from mgoin May 28, 2025 19:32
@mergify mergify bot added the tpu Related to Google TPUs label May 28, 2025
@yaochengji yaochengji added the ready ONLY add when PR is ready to merge/full CI is needed label May 28, 2025
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry 😓 thank you!

@mgoin mgoin enabled auto-merge (squash) May 28, 2025 23:42
@vllm-bot vllm-bot merged commit 8e882ff into vllm-project:main May 29, 2025
74 of 76 checks passed
amitm02 pushed a commit to amitm02/vllm that referenced this pull request Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed tpu Related to Google TPUs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants