Skip to content

Conversation

AaruniAggarwal
Copy link
Contributor

@AaruniAggarwal AaruniAggarwal commented Jun 6, 2025

Currently testcase namedtests/models/language/pooling/test_embedding.py::test_models[half-BAAI/bge-base-en-v1.5] in buildkite job for IBM Power is failing due to:

ERROR: not found: /workspace/tests/models/language/pooling/test_embedding.py::test_models[half-BAAI/bge-base-en-v1.5]
(no match in any of [<Module test_embedding.py>])

This is happening as dtype is removed from testcase name, name got changed.
After updating the testcase name, it is passing.

Signed-off-by: Aaruni Aggarwal <[email protected]>
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link

github-actions bot commented Jun 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Jun 6, 2025
Copy link
Collaborator

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

pytest -v -s tests/models/language/generation/test_common.py::test_models[False-5-32-google/gemma-1.1-2b-it]
pytest -v -s tests/models/language/pooling/test_classification.py::test_models[float-jason9693/Qwen2.5-1.5B-apeach]
pytest -v -s tests/models/language/pooling/test_embedding.py::test_models[half-BAAI/bge-base-en-v1.5]"
pytest -v -s tests/models/language/pooling/test_embedding.py -m cpu_model"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will test additional one model which is intfloat/e5-mistral-7b-instruct, but I think it should be fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I intentionally added other model as well, as it is also passing for us now.

@houseroad houseroad changed the title correcting testcase name [CI][PowerPC] Use a more appropriate way to select testcase in tests/models/language/pooling/test_embedding.py Jun 7, 2025
@houseroad houseroad added the ready ONLY add when PR is ready to merge/full CI is needed label Jun 7, 2025
@houseroad houseroad merged commit c4296b1 into vllm-project:main Jun 7, 2025
57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants