[XPU][CI] add v1/core test in xpu hardware ci

[Liangliang-Ma]

This PR adds V1/core in XPU hardware CI for basic validation of vllm core functionality.
After this we will keep adding more support for xpu and increase CI scope.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Summary of Changes

Hello @Liangliang-Ma, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a basic hardware CI test for XPU to validate the core functionality of vllm. It modifies the CI script to include pytest execution and removes an unnecessary check related to speculative decoding in the XPU platform code. The goal is to establish a foundation for more comprehensive XPU support and CI coverage.

Highlights

• XPU Hardware CI: Added a basic validation test for vllm core functionality on XPU hardware.
• Test Execution: The CI script now executes pytest on the v1/core directory in addition to running the existing example.
• XPU Platform: Removed the check for speculative decoding support in XPU platform, as it was raising a NotImplementedError.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds v1/core tests to the XPU hardware CI for validating core functionality. The changes include updating the CI script to run pytest and removing a check that previously disabled speculative decoding on XPU.

My review focuses on two main points:

1. Improving the reliability of the CI script to ensure it fails correctly if any of its commands fail.
2. Seeking clarification on the removal of the speculative decoding check for XPU to prevent potential regressions or silent failures in the new tests.

Overall, the changes are straightforward and align with the goal of expanding XPU test coverage.

[gemini-code-assist]

The two commands inside sh -c are executed sequentially. If the first command (generate.py) fails, the second command (pytest) will still run. The exit code of the sh -c block will then be the exit code of pytest, which could mask the failure of the first command and lead to the CI job passing incorrectly.

To make the CI script more robust, you should ensure that the script exits if any command fails. You can achieve this by either adding set -e at the beginning of the script block or by chaining the commands with &&.

Example with set -e:

sh -c '
set -e
VLLM_USE_V1=1 python3 examples/offline_inference/basic/generate.py ...
pytest -v -s v1/core
'

Example with &&:

sh -c '
VLLM_USE_V1=1 python3 examples/offline_inference/basic/generate.py ... && pytest -v -s v1/core
'

[DarkLight1337]

The XPU CI is failing, PTAL

[Liangliang-Ma]

The XPU CI is failing, PTAL

@DarkLight1337 Thanks. Issue Solved. I see the xpu CI is passed now.