-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[V0 Deprecation] add clear messages for deprecated models #21424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: youkaichao <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to provide clearer error messages for deprecated models by introducing a dedicated check. The implementation correctly identifies when a deprecated model is being used. However, there is a critical bug in how the deprecated model's information is retrieved, which could lead to a KeyError
and crash the application under certain conditions. I've provided a code suggestion to fix this issue and make the error message more specific and helpful to the user.
Signed-off-by: youkaichao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I left a nit
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
the error message will look like:
|
Signed-off-by: youkaichao <[email protected]> Signed-off-by: qizixi <[email protected]>
Signed-off-by: youkaichao <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: youkaichao <[email protected]>
The model was deprecated in #21217 . Let's leave a clear error message and guide users to use which versions.