Skip to content

Conversation

youkaichao
Copy link
Member

The model was deprecated in #21217 . Let's leave a clear error message and guide users to use which versions.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to provide clearer error messages for deprecated models by introducing a dedicated check. The implementation correctly identifies when a deprecated model is being used. However, there is a critical bug in how the deprecated model's information is retrieved, which could lead to a KeyError and crash the application under certain conditions. I've provided a code suggestion to fix this issue and make the error message more specific and helpful to the user.

@mergify mergify bot added the new-model Requests to new models label Jul 23, 2025
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I left a nit

Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
@youkaichao
Copy link
Member Author

the error message will look like:

ValueError: Model architecture Phi3SmallForCausalLM was supported in vLLM until version 0.9.2, and is not supported anymore. Please use an older version of vLLM if you want to use this model architecture.

@DarkLight1337 DarkLight1337 added this to the v0.10.0 milestone Jul 23, 2025
@vllm-bot vllm-bot merged commit 2f5c14d into vllm-project:main Jul 23, 2025
14 checks passed
@youkaichao youkaichao deleted the previous_models branch July 23, 2025 08:00
zixi-qi pushed a commit to zixi-qi/vllm that referenced this pull request Jul 23, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
Pradyun92 pushed a commit to Pradyun92/vllm that referenced this pull request Aug 6, 2025
@hmellor hmellor changed the title add clear messages for deprecated models [V0 Deprecation] add clear messages for deprecated models Aug 6, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-model Requests to new models
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants