-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Refactor] Fix Compile Warning #1444-D #21462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Fix Compile Warning #1444-D #21462
Conversation
Signed-off-by: yewentao256 <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a compile-time deprecation warning for cub::Sum
on CUDA by replacing it with the recommended cuda::std::plus<float>
. The change is well-implemented using a type alias AddOp
to handle the platform-specific code for CUDA and ROCm, ensuring that ROCm builds continue to use cub::Sum
which is not deprecated on that platform. The changes are correct, targeted, and improve the maintainability of the codebase by resolving the warning. The code modifications are sound, and I have no further feedback.
@houseroad CC, thanks~ |
This seems safe, thanks |
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Purpose
A follow up PR for #21208
Fix Compile Warning 1444-D: type "cub::CUB_200802_SM_1000::Sum" was declared deprecated ("use cuda::std::plus instead")
Now tested on AMD MI300, this version should work.
Test