-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Bugfix] Fix OOM tests in initialization test #21921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Isotr0py <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix out-of-memory (OOM) errors in the model initialization tests, specifically by re-enabling tests that were previously skipped. The changes look solid and well-targeted.
Key changes include:
- Removing the
pytest.skip
forGlm4vForConditionalGeneration
,GraniteSpeechForConditionalGeneration
, andKimiVLForConditionalGeneration
intests/models/test_initialization.py
. - Adding an override for
audio_config
in the test setup to reduce memory usage for audio models, which is a good proactive measure. - Correcting the initialization of the language model in
Glm4vForConditionalGeneration
by explicitly passing thetext_config
. This is a crucial fix that ensures test-specific configuration overrides are properly applied, and it also improves the correctness of the model initialization in general.
The changes are logical and directly address the OOM issue. I don't see any issues of high or critical severity. Well done.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, see if the test passes now
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: x22x22 <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Isotr0py <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Signed-off-by: Isotr0py <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
tests/models/test_initialization.py
Test Plan
Test Result
(Optional) Documentation Update