Skip to content

Conversation

Isotr0py
Copy link
Member

@Isotr0py Isotr0py commented Jul 30, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

  • Fix skipped OOM tests in tests/models/test_initialization.py

Test Plan

pytest -s -v tests/models/test_initialization.py

Test Result

  • Previous three OOM tests should pass now

(Optional) Documentation Update

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 30, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix out-of-memory (OOM) errors in the model initialization tests, specifically by re-enabling tests that were previously skipped. The changes look solid and well-targeted.

Key changes include:

  • Removing the pytest.skip for Glm4vForConditionalGeneration, GraniteSpeechForConditionalGeneration, and KimiVLForConditionalGeneration in tests/models/test_initialization.py.
  • Adding an override for audio_config in the test setup to reduce memory usage for audio models, which is a good proactive measure.
  • Correcting the initialization of the language model in Glm4vForConditionalGeneration by explicitly passing the text_config. This is a crucial fix that ensures test-specific configuration overrides are properly applied, and it also improves the correctness of the model initialization in general.

The changes are logical and directly address the OOM issue. I don't see any issues of high or critical severity. Well done.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, see if the test passes now

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) July 30, 2025 10:10
@vllm-bot vllm-bot merged commit 6e599ee into vllm-project:main Jul 30, 2025
76 of 81 checks passed
@Isotr0py Isotr0py deleted the fix-glm41-oom branch July 30, 2025 15:37
liuyumoye pushed a commit to liuyumoye/vllm that referenced this pull request Jul 31, 2025
vadiklyutiy pushed a commit to CentML/vllm that referenced this pull request Aug 5, 2025
x22x22 pushed a commit to x22x22/vllm that referenced this pull request Aug 5, 2025
npanpaliya pushed a commit to odh-on-pz/vllm-upstream that referenced this pull request Aug 6, 2025
jinzhen-lin pushed a commit to jinzhen-lin/vllm that referenced this pull request Aug 9, 2025
noamgat pushed a commit to noamgat/vllm that referenced this pull request Aug 9, 2025
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
HeJunyan added a commit to HeJunyan/vllm-fork that referenced this pull request Aug 20, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
HeJunyan added a commit to HeJunyan/vllm-fork that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants