-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Migrate MllamaImagePixelInputs to TensorSchema #22020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully migrates MllamaImagePixelInputs
from a TypedDict
to the more structured TensorSchema
. This change enhances type safety and enables runtime shape validation, which is a great improvement for input contract enforcement and overall code clarity. The implementation is clean, correct, and aligns well with the stated goal of standardizing multi-modal input definitions. The changes look good to me.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Benji Beck <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: root <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Signed-off-by: Benji Beck <[email protected]> Co-authored-by: Cyrus Leung <[email protected]>
Purpose
This PR migrates MllamaImagePixelInputs from a TypedDict-based definition to a structured TensorSchema model with runtime shape validation. This brings it in line with recent changes to Phi3VImagePixelInputs, and is part of a broader effort to improve input contract enforcement and debug-ability across multi-modal models.
Test Plan
Confirm validation works via standalone tests in tests/standalone_test/test_tensor_schema.py and rely on CI to check integration.
Test Result