-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Bugfix] Misaligned params in TreeAttentionImpl #22226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: DarkLight1337 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug in TreeAttentionImpl
caused by a mismatched parameter blocksparse_params
in its __init__
method. The change correctly removes this parameter and its corresponding check, resolving the argument conflict. The associated removal of an unused Any
import is also a good cleanup. The fix is straightforward and correct.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Noam Gat <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Tree attention is still broken because it conflicts with #21217 causing misaligned args to be passed to the model (notably
attn_type
becomesNone
). This PR fixes it.cc @TheEpicDolphin
Test Plan
Test Result
(Optional) Documentation Update