-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[gpt-oss] Support tool call and implement MCP tool server #22427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces significant new functionality by adding support for tool calls for gpt-oss
models and implementing an MCP (Model Component Protocol) tool server. The changes span across API protocols, serving logic, and utility functions. While the implementation is largely well-structured, I have identified a few critical issues that need to be addressed. These include an incorrect Pydantic model instantiation that will cause a runtime error, and a couple of bugs in the new MCPToolServer
related to its class inheritance and method logic. Fixing these issues is crucial for the stability and correctness of the new features.
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Jinzhen Lin <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Noam Gat <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Paul Pak <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ct#22427) Signed-off-by: Chen Zhang <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Support tool call for gpt-oss model and implement MCP tool server
Test Plan
All tests in
tests/v1/entrypoints/openai/responses
to test whether it breaks existing model. Harmony integration is not tested yet.Test Result
Passed
(Optional) Documentation Update