Skip to content

Conversation

eldarkurtic
Copy link
Contributor

@eldarkurtic eldarkurtic commented Aug 7, 2025

Loading of GPTBigCodeForCausalLM is broken due to the missing prefixes and incorrect treating of scales for QKV layers (i.e. c_attn.weight_scale, which are merged into a single matrix). Before this PR quantized models would produce garbage output.
After this PR quantized models are matching the BF16 baseline output.

Copy link

github-actions bot commented Aug 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the loading of quantized BigCode models by adding necessary prefixes to layer names and correcting the handling of QKV layer scales. While the prefix additions seem correct, the change in how c_attn.weight_scale is loaded appears to be problematic and may lead to incorrect behavior or errors. The default weight loading logic for fused QKV layers seems to only update the scale for the 'query' component, leaving 'key' and 'value' scales at their default values, which is likely incorrect.

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mgoin mgoin enabled auto-merge (squash) August 8, 2025 13:43
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 8, 2025
@vllm-bot vllm-bot merged commit 10a0253 into vllm-project:main Aug 9, 2025
44 of 53 checks passed
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants