-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Fix loading of quantized BigCode models #22463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix the loading of quantized BigCode models by adding necessary prefixes to layer names and correcting the handling of QKV layer scales. While the prefix additions seem correct, the change in how c_attn.weight_scale
is loaded appears to be problematic and may lead to incorrect behavior or errors. The default weight loading logic for fused QKV layers seems to only update the scale for the 'query' component, leaving 'key' and 'value' scales at their default values, which is likely incorrect.
Signed-off-by: Eldar Kurtic <[email protected]>
3bbe5de
to
2d11f55
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Signed-off-by: Eldar Kurtic <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: Eldar Kurtic <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: Eldar Kurtic <[email protected]>
Signed-off-by: Eldar Kurtic <[email protected]>
Signed-off-by: Eldar Kurtic <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Eldar Kurtic <[email protected]>
Loading of
GPTBigCodeForCausalLM
is broken due to the missing prefixes and incorrect treating of scales for QKV layers (i.e.c_attn.weight_scale
, which are merged into a single matrix). Before this PR quantized models would produce garbage output.After this PR quantized models are matching the BF16 baseline output.