Skip to content

Conversation

ericcurtin
Copy link
Contributor

@ericcurtin ericcurtin commented Aug 11, 2025

I tested it recently in a Linux VM on macOS, works great! Although it could do with CI, I see silly bugs creep in sometimes.

@ericcurtin ericcurtin requested a review from hmellor as a code owner August 11, 2025 13:08
@mergify mergify bot added the documentation Improvements or additions to documentation label Aug 11, 2025
I tested it recently in a Linux VM on macOS, works great! Although
it could do with CI, I see silly bugs creep in sometimes.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin
Copy link
Contributor Author

@DarkLight1337 @simon-mo PTAL

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the vLLM V1 guide to document support for the aarch64 CPU architecture. The change modifies the hardware support table, adding aarch64 to the list of supported CPU architectures. This is a straightforward and valuable documentation improvement that accurately reflects the project's capabilities.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mgoin do you know the status of MacOS support?

@ericcurtin
Copy link
Contributor Author

cc @mgoin do you know the status of MacOS support?

I didn't try macOS support FWIW. I tried a Linux VM on macOS and it worked great! podman-machine/krunkit in my case.

Needed this small fix at the time because at least on this hypervisor it couldn't do numa detection stuff:

#21115

@ericcurtin
Copy link
Contributor Author

ARM CI seems pretty simplified these days on github:

https://github.blog/changelog/2025-08-07-arm64-hosted-runners-for-public-repositories-are-now-generally-available/

windows-11-arm
ubuntu-24.04-arm
ubuntu-22.04-arm

@ericcurtin
Copy link
Contributor Author

ericcurtin commented Aug 11, 2025

I do think Vulkan with macOS and MoltenVK (or even in Linux VMs via krunkit) could be really neat. Something that has been discussed with people like @rhatdan, @slp, @airlied , etc.

Vulkan solves problems as regards acceleration on a lot of hardware. And performs decently well:

https://airlied.blogspot.com/2025/07/ramalamamesa-benchmarks-on-my-hardware.html

@vllm-bot vllm-bot merged commit 3fa5b25 into vllm-project:main Aug 11, 2025
11 of 14 checks passed
@ericcurtin ericcurtin deleted the doc-fix branch August 11, 2025 14:42
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants