-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[New Model] Support Command-A-Vision #22660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for the Command-A-Vision model. The changes include a new model implementation file, along with additions to example scripts and model registries. The core logic seems sound and follows existing patterns in the codebase. However, I've identified a critical bug in the new model implementation related to an incorrect function call that will cause a runtime error. Additionally, there's a high-severity issue where a value is hardcoded, which compromises the code's generality and maintainability. Addressing these points will improve the robustness and quality of the new model support.
Signed-off-by: donglu <[email protected]>
4ef9e2a
to
f02103d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM!
cc @hmellor can you measure the perf difference compared to Transformers backend? In the future we may be able to switch fully to Transformers backend if the performance becomes on par with the custom implementation.
Sure, testing now |
Looks like running Command A Vision in the Transformers backend will require #22673 and a change on the Transformers side |
Signed-off-by: donglu <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: donglu <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: donglu <[email protected]>
Signed-off-by: donglu <[email protected]>
Signed-off-by: donglu <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: donglu <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
Issue: #22648
Support Command-A-Vision https://huggingface.co/CohereLabs/command-a-vision-07-2025/blob/main/config.json
Test Plan
online chat
Test Result
(Optional) Documentation Update