Skip to content

Conversation

sooraj-satheesh
Copy link
Contributor

@sooraj-satheesh sooraj-satheesh commented Aug 12, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

AVX512f is optional, see #5452 . updating the docs to reflect this. Solves #18660

Test Plan

Build the docker image with --build-arg VLLM_CPU_DISABLE_AVX512=true

Test Result

Container does not crash with Illegal Instruction on a cpu without avx512f.

(Optional) Documentation Update

…tructions

AVX512f is optional, see vllm-project#5452 updating the docs to reflect this.

Signed-off-by: Sooraj S <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Aug 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the x86 CPU inference installation documentation to reflect that the avx512f flag is now optional. The changes correctly mark the flag as optional and update the warning and build instructions. I've included a suggestion to improve the clarity and grammar of the updated warning message.

docker build -f docker/Dockerfile.cpu \
--build-arg VLLM_CPU_AVX512BF16=false (default)|true \
--build-arg VLLM_CPU_AVX512VNNI=false (default)|true \
--build-arg VLLM_CPU_DISABLE_AVX512=false (default)|true \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There's an extra space before --build-arg which makes the indentation inconsistent with the other arguments. Please remove it for alignment.

Suggested change
--build-arg VLLM_CPU_DISABLE_AVX512=false (default)|true \
--build-arg VLLM_CPU_DISABLE_AVX512=true (default)|false \

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Sooraj S <[email protected]>
@bigPYJ1151
Copy link
Member

Hi @sooraj-satheesh In fact the AVX2 version is not recommend because it only has basic feature support. We recommend AVX512 version and only provides AVX512 pre-built image.

@sooraj-satheesh
Copy link
Contributor Author

@bigPYJ1151 yes but the dockerfile supports building without it and it would reduce confusion to document this. The recommendation against it can also be added to the doc.

Co-authored-by: Li, Jiang <[email protected]>
Signed-off-by: Sooraj S <[email protected]>
@vllm-bot vllm-bot merged commit 2f46579 into vllm-project:main Aug 12, 2025
6 of 8 checks passed
paulpak58 pushed a commit to paulpak58/vllm that referenced this pull request Aug 13, 2025
…y of AVX512f (vllm-project#22707)

Signed-off-by: Sooraj S <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Li, Jiang <[email protected]>
Signed-off-by: Paul Pak <[email protected]>
diegocastanibm pushed a commit to diegocastanibm/vllm that referenced this pull request Aug 15, 2025
…y of AVX512f (vllm-project#22707)

Signed-off-by: Sooraj S <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Li, Jiang <[email protected]>
Signed-off-by: Diego-Castan <[email protected]>
yiliu30 pushed a commit to yiliu30/vllm-fork that referenced this pull request Aug 19, 2025
…y of AVX512f (vllm-project#22707)

Signed-off-by: Sooraj S <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Li, Jiang <[email protected]>
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
…y of AVX512f (vllm-project#22707)

Signed-off-by: Sooraj S <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Li, Jiang <[email protected]>
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
…y of AVX512f (vllm-project#22707)

Signed-off-by: Sooraj S <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Li, Jiang <[email protected]>
Signed-off-by: Xiao Yu <[email protected]>
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
…y of AVX512f (vllm-project#22707)

Signed-off-by: Sooraj S <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Li, Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants