-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Remove Phi 4 Flash configuration workaround #22723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Harry Mellor <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes a workaround for the Phi-4-Flash model configuration. The change is predicated on the upstream model configuration on Hugging Face being fixed, as mentioned in the pull request description. This removal simplifies the codebase by eliminating a temporary patch. The change appears correct, and I have no issues to report.
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Harry Mellor <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Now that https://huggingface.co/microsoft/Phi-4-mini-flash-reasoning/discussions/6 and https://huggingface.co/microsoft/Phi-4-mini-flash-reasoning/discussions/7 have been merged, we can remove the workaround.
(The upstream code is currently broken and will be fixed imminently by https://huggingface.co/microsoft/Phi-4-mini-flash-reasoning/discussions/8)