-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Add more test scenario for tensor schema #22733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more test scenario for tensor schema #22733
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds several valuable test scenarios for the tensor schema validation logic. The new tests cover important failure cases, including invalid types within a list of tensors, rank mismatches, and missing required fields. These additions improve the test coverage for critical validation paths, enhancing the robustness of the tensor schema handling. The changes are well-implemented and correct.
fd96c89
to
e7559b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you address the pre-commit errors? |
8fe221d
to
eb764fe
Compare
Signed-off-by: teekenl <[email protected]>
eb764fe
to
6e94fe3
Compare
Signed-off-by: teekenl <[email protected]> Signed-off-by: Paul Pak <[email protected]>
Signed-off-by: teekenl <[email protected]> Signed-off-by: Diego-Castan <[email protected]>
Signed-off-by: teekenl <[email protected]>
Signed-off-by: teekenl <[email protected]>
Signed-off-by: teekenl <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: teekenl <[email protected]>
Purpose
Add more test scenario for tensor schema
Test Plan
Test Result