-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[CI] Fix tests/distributed/test_ca_buffer_sharing.py
#22849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Fix tests/distributed/test_ca_buffer_sharing.py
#22849
Conversation
Signed-off-by: ilmarkov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes a bug in CustomAllreduce.free_shared_buffer
by changing the default value of the rank
parameter from 0
to None
. The previous default value caused incorrect behavior in multi-process settings, where ranks other than 0 would attempt to free the buffer for rank 0 if the method was called without an explicit rank. With this change, the method now correctly retrieves the rank of the current process using dist.get_rank()
when no rank is provided, which is the intended behavior. The fix is clean, targeted, and resolves the issue effectively.
tests/distributed/test_ca_buffer_sharing.py
tests/distributed/test_ca_buffer_sharing.py
tests/distributed/test_ca_buffer_sharing.py
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
all failures are known and addressed by other PRs. This is good to merge |
…22849) Signed-off-by: ilmarkov <[email protected]> Co-authored-by: ilmarkov <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
…22849) Signed-off-by: ilmarkov <[email protected]> Co-authored-by: ilmarkov <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
…22849) Signed-off-by: ilmarkov <[email protected]> Co-authored-by: ilmarkov <[email protected]> Co-authored-by: Wentao Ye <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
…22849) Signed-off-by: ilmarkov <[email protected]> Co-authored-by: ilmarkov <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
…22849) Signed-off-by: ilmarkov <[email protected]> Co-authored-by: ilmarkov <[email protected]> Co-authored-by: Wentao Ye <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…22849) Signed-off-by: ilmarkov <[email protected]> Co-authored-by: ilmarkov <[email protected]> Co-authored-by: Wentao Ye <[email protected]>
Fix #18589
Fix #22840
Changes default parameter of
rank
argument to None instead of 0 inCustomAllreduce.free_shared_buffer
. It has to be None as by default it the method will just get it fromdist.get_rank()
supported_models.md
andexamples
for a new model.Purpose
Test Plan
Test Result
(Optional) Documentation Update