-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Move checklist in PR template #22852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Luka Govedic <[email protected]>
Signed-off-by: Luka Govedic <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the pull request template by moving the checklist to a collapsible section at the bottom and updates the corresponding cleanup script. The changes are consistent and correctly implemented. I have reviewed the changes and found no issues of high or critical severity in the modified code.
Signed-off-by: Luka Govedic <[email protected]>
Signed-off-by: Luka Govedic <[email protected]>
Signed-off-by: Luka Govedic <[email protected]>
Signed-off-by: Luka Govedic <[email protected]>
Signed-off-by: Luka Govedic <[email protected]>
Signed-off-by: Luka Govedic <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: Luka Govedic <[email protected]>
Purpose
Modify the PR description template for better notification readability.
Test Plan
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.