Skip to content

Conversation

LucasWilkinson
Copy link
Collaborator

@LucasWilkinson LucasWilkinson commented Aug 15, 2025

Purpose

vLLM side of vllm-project/flash-attention#80

Test Plan + Result

@sarckk confirms this fixes his issue; may help with some of the H100 related issues in #19483 (not the A100 related ones; this issue appears to have multiple independent IMAs being discussed)

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Aug 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the flash-attention dependency to a new commit, presumably to incorporate a bug fix for IMA in FlashAttention v3 as indicated by the title. My review focuses on improving the maintainability of this dependency management. I've suggested adding a comment to the cmake file to provide context for the specific commit hash being used. This will help future developers understand the reason for this pin. It is also highly recommended to provide details on how this change was tested in the pull request description to ensure it fixes the intended bug without introducing regressions, especially given the 'footgun' warning in the cmake file regarding this dependency.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

For better maintainability, it's good practice to add a comment explaining why this specific commit hash is being used. This provides context for future developers who might need to update this dependency. You could reference the bug fix or the associated pull request.1

          # From https://github.com/vllm-project/flash-attention/pull/80 for IMA fix in FA3
          GIT_TAG 4c6a539a4d69241c612fea88b6af6c46d05eb542

Style Guide References

Footnotes

  1. Code should be well-commented to explain the purpose and origin of 'magic' values like raw commit hashes, which improves long-term maintainability.

@LucasWilkinson LucasWilkinson changed the title [BugFix] Potential Fix for IMA in FA3 [WIP][BugFix] Potential Fix for IMA in FA3 Aug 15, 2025
@LucasWilkinson LucasWilkinson force-pushed the lwilkinson/potential-ima-fix branch from abbbe77 to 3c1a3a3 Compare August 15, 2025 20:54
@LucasWilkinson LucasWilkinson changed the title [WIP][BugFix] Potential Fix for IMA in FA3 [BugFix] Fix for IMA in FA3 Aug 15, 2025
@LucasWilkinson LucasWilkinson added this to the v0.10.1 milestone Aug 15, 2025
@LucasWilkinson LucasWilkinson changed the title [BugFix] Fix for IMA in FA3 [BugFix] Fix for IMA in FA3 varlen combine Aug 15, 2025
Copy link

mergify bot commented Aug 15, 2025

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @LucasWilkinson.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Aug 15, 2025
Signed-off-by: Lucas Wilkinson <[email protected]>
@LucasWilkinson LucasWilkinson force-pushed the lwilkinson/potential-ima-fix branch from 3c1a3a3 to 6bbcf5b Compare August 16, 2025 03:58
@mergify mergify bot removed the needs-rebase label Aug 16, 2025
@cjackal
Copy link
Contributor

cjackal commented Aug 16, 2025

The fastcheck fails due to temporary aws s3 connection error, FYI.

@simon-mo simon-mo enabled auto-merge (squash) August 17, 2025 15:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 17, 2025
@simon-mo simon-mo disabled auto-merge August 17, 2025 15:38
@simon-mo simon-mo enabled auto-merge (squash) August 17, 2025 15:38
@simon-mo simon-mo disabled auto-merge August 17, 2025 15:52
@simon-mo simon-mo merged commit 292084e into vllm-project:main Aug 17, 2025
44 of 82 checks passed
divakar-amd pushed a commit to divakar-amd/vllm_upstream that referenced this pull request Aug 20, 2025
cyang49 pushed a commit to cyang49/vllm that referenced this pull request Aug 20, 2025
djmmoss pushed a commit to djmmoss/vllm that referenced this pull request Aug 21, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants