[Bugfix] fix IntermediateTensors equal method

[andyxning]

Purpose

Compare struct fields in IntermediateTensors equal method. I.e., compare tensors.

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

NA

Essential Elements of an Effective PR Description Checklist

• The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
• The test plan, such as providing test command.
• The test results, such as pasting the results comparison before and after, or e2e results
• (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

[github-actions]

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

[gemini-code-assist]

Code Review

This pull request aims to fix a bug in the __eq__ method of the IntermediateTensors class. The original implementation was incorrect. The proposed change is an improvement but is still not fully correct for comparing dictionaries of PyTorch tensors. My review provides a corrected implementation for comparing the tensors attribute and points out that another attribute, kv_connector_output, is also missing from the comparison.

[gemini-code-assist]

The dictionary comparison self.tensors == other.tensors is incorrect for dictionaries of PyTorch tensors. tensor1 == tensor2 performs an element-wise comparison and returns a boolean tensor, not a scalar boolean. This will cause the dictionary comparison to almost always return False if tensors have more than one element. You should iterate through the dictionary and use torch.equal() to compare tensors.

Additionally, for a complete equality check, the kv_connector_output attribute should also be compared. I've left that out of the suggestion for brevity, but it should be added for correctness.

    def __eq__(self, other: object):
        if not isinstance(other, self.__class__):
            return False
        if self.tensors.keys() != other.tensors.keys():
            return False
        return all(
            torch.equal(self.tensors[k], other.tensors[k])
            for k in self.tensors)

[huachenheli]

Add a unit test?

[andyxning]

Done.