-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Misc] Fix backward compatibility from #23030 #23070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Roger Wang <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix a backward compatibility issue with multi-modal embeddings. The change modifies a return value in vllm/multimodal/base.py
. However, this change introduces a type inconsistency within the from_seq_group
function, where one return path now provides a dict
while another provides a MultiModalKwargs
object. This violates the function's type hint and can lead to runtime errors. This should be addressed to ensure consistent behavior.
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
Signed-off-by: Roger Wang <[email protected]>
All CI has passed in 5ea6a70. Force merging since all the following PRs only address pre-commit and doc build |
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]>
…ct#23070) Signed-off-by: Roger Wang <[email protected]> Co-authored-by: Roger Wang <[email protected]>
Purpose
#23030 broke a v0 compatibility with mm embeddings as input and therefore the multimodal test. This PR fixes it.
Test Plan
pytest -v -s --ignore models/multimodal/generation/test_whisper.py --ignore models/multimodal/test_tensor_schema.py models/multimodal -m core_model
Test Result
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.