-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Log] Warning Once for Cutlass MLA #23137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Log] Warning Once for Cutlass MLA #23137
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to reduce log spam from Cutlass MLA by replacing logger.warning
with logger.warning_once
. While the intention is correct, the implementation of warning_once
in vllm/logger.py
is flawed. It uses functools.lru_cache
on a function that takes a logging.Logger
object as an argument. Since Logger
objects are not hashable, this will lead to a TypeError
at runtime, causing a crash. This critical issue needs to be fixed in vllm/logger.py
for this change to work correctly.
Signed-off-by: yewentao256 <[email protected]>
838a5fe
to
c22485c
Compare
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Duncan Moss <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Signed-off-by: yewentao256 <[email protected]>
Purpose
Warning Once for Cutlass MLA
To avoid