Skip to content

Conversation

andyxning
Copy link
Contributor

@andyxning andyxning commented Aug 19, 2025

Purpose

VLLM_TORCH_PROFILER_DIR is absolute path according to the comment.

Test Plan

NA

Test Result

NA

(Optional) Documentation Update

NA

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the handling of VLLM_TORCH_PROFILER_DIR to ensure it's an absolute path. The change from os.path.expanduser to os.path.abspath is a good step, but it introduces a regression by not handling tilde (~) expansion for home directories. My review includes a suggestion to combine both functions to correctly handle all path variations, ensuring the path is both expanded and absolute.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@andyxning andyxning force-pushed the fix_VLLM_TORCH_PROFILER_DIR_to_absolute_path branch from e1acd9d to 981b233 Compare August 19, 2025 16:43
@ProExpertProg ProExpertProg added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 20, 2025
@ProExpertProg ProExpertProg enabled auto-merge (squash) August 20, 2025 17:31
auto-merge was automatically disabled August 21, 2025 02:10

Head branch was pushed to by a user without write access

@andyxning andyxning force-pushed the fix_VLLM_TORCH_PROFILER_DIR_to_absolute_path branch 2 times, most recently from e1729a0 to ad5b546 Compare August 21, 2025 08:45
@andyxning andyxning force-pushed the fix_VLLM_TORCH_PROFILER_DIR_to_absolute_path branch from ad5b546 to 1e76e6b Compare August 21, 2025 12:37
@ProExpertProg ProExpertProg merged commit 3496274 into vllm-project:main Aug 21, 2025
37 checks passed
@andyxning andyxning deleted the fix_VLLM_TORCH_PROFILER_DIR_to_absolute_path branch August 22, 2025 02:08
Xu-Wenqing pushed a commit to Xu-Wenqing/vllm that referenced this pull request Aug 23, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
mengxingkongzhouhan pushed a commit to mengxingkongzhouhan/vllm that referenced this pull request Aug 30, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants