-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[Misc] fix VLLM_TORCH_PROFILER_DIR to absolute path #23191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] fix VLLM_TORCH_PROFILER_DIR to absolute path #23191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix the handling of VLLM_TORCH_PROFILER_DIR
to ensure it's an absolute path. The change from os.path.expanduser
to os.path.abspath
is a good step, but it introduces a regression by not handling tilde (~
) expansion for home directories. My review includes a suggestion to combine both functions to correctly handle all path variations, ensuring the path is both expanded and absolute.
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
e1acd9d
to
981b233
Compare
Head branch was pushed to by a user without write access
e1729a0
to
ad5b546
Compare
Signed-off-by: Andy Xie <[email protected]>
ad5b546
to
1e76e6b
Compare
…#23191) Signed-off-by: Andy Xie <[email protected]> Signed-off-by: root <[email protected]>
…#23191) Signed-off-by: Andy Xie <[email protected]>
…#23191) Signed-off-by: Andy Xie <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…#23191) Signed-off-by: Andy Xie <[email protected]>
…#23191) Signed-off-by: Andy Xie <[email protected]>
…#23191) Signed-off-by: Andy Xie <[email protected]>
…#23191) Signed-off-by: Andy Xie <[email protected]>
Purpose
VLLM_TORCH_PROFILER_DIR
is absolute path according to the comment.Test Plan
NA
Test Result
NA
(Optional) Documentation Update
NA
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.