Skip to content

Conversation

patemotter
Copy link
Contributor

@patemotter patemotter commented Aug 25, 2025

Fixes errors related to prompt_token_ids not being a parameter in LLM.generate() impacting TPU-related tests.

Purpose

Fix CI/CD for TPU.

Test Plan

Tested on failed TPU test scripts (bash .buildkite/scripts/hardware_ci/run-tpu-v1-test.sh)

Test Result

Successful.

(Optional) Documentation Update


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the ci/build label Aug 25, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a CI/CD failure on TPU by pinning the lm-eval dependency to a specific git commit containing a necessary fix. The change is appropriate for unblocking the CI. My review includes a suggestion to add a TODO comment to both modified scripts. This will serve as a reminder to revert to a stable, released version of the package once the fix is available on PyPI, which is important for long-term maintainability and security.

@yaochengji yaochengji changed the title Fixes prompt_token_ids error in tpu tests. [TPU][CI] Fixes prompt_token_ids error in tpu tests. Aug 25, 2025
@yaochengji yaochengji changed the title [TPU][CI] Fixes prompt_token_ids error in tpu tests. [TPU][Bugfix] Fixes prompt_token_ids error in tpu tests. Aug 25, 2025
Copy link
Collaborator

@yaochengji yaochengji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaochengji yaochengji enabled auto-merge (squash) August 25, 2025 19:03
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 25, 2025
auto-merge was automatically disabled August 25, 2025 19:25

Head branch was pushed to by a user without write access

@patemotter patemotter force-pushed the patemotter/tpu-lm-eval-fix branch from e691d92 to 8548835 Compare August 25, 2025 19:25
@yaochengji yaochengji merged commit c34c82b into vllm-project:main Aug 25, 2025
15 checks passed
tc-mb pushed a commit to tc-mb/vllm that referenced this pull request Aug 27, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants