-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[TPU][Bugfix] Fixes prompt_token_ids error in tpu tests. #23574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPU][Bugfix] Fixes prompt_token_ids error in tpu tests. #23574
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request resolves a CI/CD failure on TPU by pinning the lm-eval
dependency to a specific git commit containing a necessary fix. The change is appropriate for unblocking the CI. My review includes a suggestion to add a TODO
comment to both modified scripts. This will serve as a reminder to revert to a stable, released version of the package once the fix is available on PyPI, which is important for long-term maintainability and security.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Pate Motter <[email protected]>
Head branch was pushed to by a user without write access
e691d92
to
8548835
Compare
…t#23574) Signed-off-by: Pate Motter <[email protected]> Signed-off-by: tc-mb <[email protected]>
…t#23574) Signed-off-by: Pate Motter <[email protected]>
…t#23574) Signed-off-by: Pate Motter <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
…t#23574) Signed-off-by: Pate Motter <[email protected]>
…t#23574) Signed-off-by: Pate Motter <[email protected]>
…t#23574) Signed-off-by: Pate Motter <[email protected]>
Fixes errors related to
prompt_token_ids
not being a parameter inLLM.generate()
impacting TPU-related tests.Purpose
Fix CI/CD for TPU.
Test Plan
Tested on failed TPU test scripts (
bash .buildkite/scripts/hardware_ci/run-tpu-v1-test.sh
)Test Result
Successful.
(Optional) Documentation Update
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.