Skip to content

Conversation

youzhedian
Copy link
Contributor

This PR fix the reduce_scatter interface in pynccl-wrapper. The old implementation fails when scatter_dim != 0 because the input_tensor is incorrectly supplied, it doesn’t use the tensor rearranged by movedim.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the reduce_scatter function where the wrong tensor was being passed to the underlying pynccl communication primitive. The fix ensures that the tensor with the rearranged dimensions is used. However, a similar bug exists in the reduce_scatterv function within the same file, which has been overlooked. I've added a comment to highlight this critical issue, as fixing it would ensure correctness and consistency across related communication operations.

@youkaichao
Copy link
Member

cc @tlrmchlsmth

@youkaichao youkaichao enabled auto-merge (squash) August 26, 2025 15:26
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 26, 2025
@vllm-bot vllm-bot merged commit c7c80af into vllm-project:main Aug 27, 2025
50 of 53 checks passed
tc-mb pushed a commit to tc-mb/vllm that referenced this pull request Aug 27, 2025
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants