Skip to content

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Aug 27, 2025

Purpose

Since llama and chatglm models can test all LoRA layers, remove the LoRA tests for baichuan and phi2 to reduce CI pressure

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: Jee Jee Li <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes redundant LoRA model tests for baichuan and phi2 to reduce CI pressure. The changes are straightforward, involving the deletion of two test files and a related test fixture. The changes align with the stated purpose. I've identified one minor issue: an unused test fixture for baichuan that was left behind. Removing it would complete the cleanup. Overall, this is a good change for optimizing the CI process.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 27, 2025 04:05
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 27, 2025
@DarkLight1337 DarkLight1337 merged commit 9de25c2 into vllm-project:main Aug 27, 2025
23 of 25 checks passed
@jeejeelee jeejeelee deleted the remove-lora-model branch August 27, 2025 08:50
epwalsh pushed a commit to epwalsh/vllm that referenced this pull request Aug 28, 2025
xiao-llm pushed a commit to xiao-llm/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Aug 28, 2025
zhewenl pushed a commit to zhewenl/vllm that referenced this pull request Sep 3, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants