[Doc]: upgrade version of crate-ci tool for improved typo detection #23755
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Durand <[email protected]>
didier-durand
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request intends to upgrade the crate-ci/typos pre-commit hook. However, the target version v1.35.5 is invalid as it does not exist in the upstream repository. This would break the CI and local development environments for anyone pulling this change. I have provided a critical review comment to correct the version to the latest valid one.
|
Hi, it seem that Gemini doesn't recognize 1.35.5 which exists: https://github.com/crate-ci/typos/releases/tag/v1.35.5 |
hmellor
approved these changes
Aug 27, 2025
|
Thanks for the PR @didier-durand! |
DarkLight1337
approved these changes
Aug 27, 2025
epwalsh
pushed a commit
to epwalsh/vllm
that referenced
this pull request
Aug 28, 2025
…llm-project#23755) Signed-off-by: Didier Durand <[email protected]>
xiao-llm
pushed a commit
to xiao-llm/vllm
that referenced
this pull request
Aug 28, 2025
…llm-project#23755) Signed-off-by: Didier Durand <[email protected]> Signed-off-by: Xiao Yu <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Aug 28, 2025
…llm-project#23755) Signed-off-by: Didier Durand <[email protected]>
zhewenl
pushed a commit
to zhewenl/vllm
that referenced
this pull request
Sep 3, 2025
…llm-project#23755) Signed-off-by: Didier Durand <[email protected]>
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
…llm-project#23755) Signed-off-by: Didier Durand <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve typo detection via version upgrade for crate-ci typo tool.
This is based on comment /. request #23636 (comment) by @hmellor
Test Plan
N/A
Test Result
N/A