[V0 Deprecation] Remove V0 Samplers test #23862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Woosuk Kwon <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes test files for the deprecated V0 sampler, which is a good cleanup step. The changes are correct and align with the goal of phasing out V0 components. As a next step, the V0 sampler implementation in vllm/model_executor/layers/sampler.py could also be removed to complete the deprecation.
njhill
reviewed
Aug 29, 2025
|
|
||
| @pytest.fixture | ||
| def vllm_model(vllm_runner, monkeypatch): | ||
| # This file relies on V0 internals. |
There was a problem hiding this comment.
@WoosukKwon this one doesn't look V0 specific to me despite this comment... could we just change it to use V1?
There was a problem hiding this comment.
@njhill I think we have a counterpart in V1:
eicherseiji
pushed a commit
to eicherseiji/vllm
that referenced
this pull request
Sep 9, 2025
FeiDaLI
pushed a commit
to FeiDaLI/vllm
that referenced
this pull request
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.