Skip to content

Conversation

Potabk
Copy link
Contributor

@Potabk Potabk commented Sep 8, 2025

Purpose

When one want to use models from modelscope, there appears an issue in the quantization scenario which will only get quant_config from huggingface

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
@Potabk Potabk requested a review from 22quinn as a code owner September 8, 2025 08:08
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses an issue with loading quantization configurations for models from ModelScope. The fix involves ensuring the model is downloaded before its path is checked, which is a sound approach. However, this introduces a new function, maybe_download_from_modelscope, that is nearly identical to an existing function in another file. I've added a high-severity comment to highlight this code duplication and suggest a refactoring to improve maintainability.

Signed-off-by: wangli <[email protected]>
Signed-off-by: wangli <[email protected]>
Copy link
Member

@Isotr0py Isotr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look reasonable to me!

@Isotr0py Isotr0py enabled auto-merge (squash) September 8, 2025 08:55
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Sep 8, 2025
@Isotr0py Isotr0py merged commit 5e537f4 into vllm-project:main Sep 8, 2025
48 checks passed
eicherseiji pushed a commit to eicherseiji/vllm that referenced this pull request Sep 9, 2025
skyloevil pushed a commit to skyloevil/vllm that referenced this pull request Sep 13, 2025
FeiDaLI pushed a commit to FeiDaLI/vllm that referenced this pull request Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants